The thing with Roy is that he was a screw up but he has had his life pretty well together since the 90s and that stigma of him being a loser, screw up, etc. only came back because of Cry for Justice/Rise of Arsenal and RHatO. Didio and co thought making a Roy a villain would be a good idea so they murdered Lian and maimed Roy. Then DC decided to reboot before anymore damage was done. But then RHatO hurt him in a different way. Regressed him back to being an addict (alcoholic) and erased all his character development.
During the Jurgens/Grayson era of Titans, Roy was a single father which is very unique for a superhero. He was a great father and solid member of his team. The idea of him being a terrible person was gone at this point. Really the only flaw he still had was he still kinda had a thing for Cheshire and was still hotheaded.