I don't think either character has anything to worry about. Carol has the MCU hype machine behind her and Diana has the only critically and financially successful film in the current stable of DC movies thus far. There's plenty of room for them to both do well.