I was just catching up on "Black Lightning" and had a thought that I enjoyed it more when Jefferson was the principal at the school. It really showed who he was as a man, which informed who he was as a hero, and gave the show more interesting story possibilities than just the hero v. bad guy stories.
Anyway, that lead me to think of which other heroes really benefit from having a job. Some heroes are almost inseparable from theirs - Superman as Clark Kent at the Daily Planet is the clearest example. Hal Jordan was off in space for almost all of "Hal Jordan & the Green Lantern Corps," but Venditti made it impossible to not know that Hal Jordan was a pilot - it's just part of who he is. I think people who don't even follow him know that - as oppose to say, Firestorm - has Ronnie Raymond ever even had a job? I have no idea. There's been a definite shift away from the "hero with a secret identity and day job" trope in recent decades, but for some it still works.
Which other heroes do you feel really benefit, or need, to have their job as an important part of their identity?