My actual favorite era is not when I was a kid. I was a kid during the heyday of the Didio/Johns’s era (around Sinestro Corps War), but I much prefer the late 80s and 90s. JLI, Levitz LOSH, Morrison’s JLA, Vertigo, Starman etc.
The 90s had so many great short lived series. Aztek, Chronos, Chase, Ressurection Man etc. I think DC as a whole was at its best probably around DC One Million.