My problem with the way how Percy is handling things about their relationship in Green Arrow is how idealized their dynamic is being portrayed. He's trying to sell the idea that they're meant to be together so hard that is just unrealistic, especially considering how in the past their romance was much more complicated than that and the problematic nature of how Ollie constantly cheated on Dinah and how she simply accepted it gave much more layers to their characters, they're simply not meant for one another, that's how their history works (The fact that Percy reintroduced it in such a fast and rushed way made things even worse).
I believe that both Ollie and Dinah do care for each other but they simply don't work well at all as a couple, actually Ollie doesn't work well in any serious relationship.